Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61669718
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,64 @@ public UnsafeArrayData copy
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12612#discussion_r61655071
--- Diff: core/src/main/scala/org/apache/spark/NewAccumulator.scala ---
@@ -0,0 +1,391 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/12776#issuecomment-215822166
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/12776#issuecomment-215784559
Test failure was not related to the patch:
```
[info] - analyze MetastoreRelations *** FAILED *** (483 milliseconds)
[info] 3426 did not equal 11624
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12776#discussion_r61585127
--- Diff: core/src/main/scala/org/apache/spark/NewAccumulator.scala ---
@@ -209,9 +210,9 @@ private[spark] object AccumulatorContext {
*/
def
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12776#discussion_r61576634
--- Diff: core/src/main/scala/org/apache/spark/NewAccumulator.scala ---
@@ -209,9 +210,9 @@ private[spark] object AccumulatorContext {
*/
def
GitHub user tedyu opened a pull request:
https://github.com/apache/spark/pull/12776
Use ConcurrentHashMap in place of HashMap for NewAccumulator.originals
## What changes were proposed in this pull request?
This PR proposes to use ConcurrentHashMap in place of HashMap
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12773#discussion_r61547437
--- Diff: core/src/main/scala/org/apache/spark/NewAccumulator.scala ---
@@ -197,7 +199,7 @@ private[spark] object AccumulatorContext {
* TODO: Don't
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12259#discussion_r61474690
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/UDTRegistration.scala ---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12634#discussion_r60845292
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -412,20 +412,26 @@ class Analyzer
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12619#discussion_r60830595
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetQuerySuite.scala
---
@@ -589,6 +590,30 @@ class ParquetQuerySuite
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/12639#issuecomment-213747456
@davies
Please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user tedyu opened a pull request:
https://github.com/apache/spark/pull/12639
[SPARK-14856] Correct message in assertion for 'returning batch for wide
table'
## What changes were proposed in this pull request?
There was a typo in the message for second assertion
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12619#discussion_r60828879
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetQuerySuite.scala
---
@@ -589,6 +590,30 @@ class ParquetQuerySuite
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12490#discussion_r60685910
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
---
@@ -0,0 +1,264 @@
+/*
+ * Licensed to the Apache
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12435#discussion_r60494228
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSinkLog.scala
---
@@ -0,0 +1,278 @@
+/*
+ * Licensed
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12435#discussion_r60493854
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSinkLog.scala
---
@@ -0,0 +1,278 @@
+/*
+ * Licensed
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12361#discussion_r60339109
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala
---
@@ -0,0 +1,530 @@
+/*
+ * Licensed
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/12457#issuecomment-212014799
It seems this PR can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/12457#issuecomment-211546852
@hbhanawat
What do you think ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/12457#issuecomment-211121052
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11723#discussion_r59991684
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -140,6 +140,13 @@ private[spark] class
GitHub user tedyu opened a pull request:
https://github.com/apache/spark/pull/12457
[SPARK-13904] Add exit code parameter to exitExecutor()
## What changes were proposed in this pull request?
This PR adds exit code parameter to exitExecutor() so that caller can
specify
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11723#discussion_r59988347
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -140,6 +140,13 @@ private[spark] class
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10664#discussion_r59631589
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -566,4 +576,88 @@ object PrefixSpan extends Logging {
@Since("
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12315#discussion_r59519389
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java
---
@@ -149,25 +148,35 @@ public TransportClient
Github user tedyu closed the pull request at:
https://github.com/apache/spark/pull/12276
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12279#discussion_r59152083
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
---
@@ -200,8 +150,26 @@ void readBatch(int
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/12276#issuecomment-207966319
@mengxr
Is there anything I can do on this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/12276#issuecomment-207866374
@mengxr
I saw you reverted [SPARK-14462].
[SPARK-14462] + this PR would pass the build.
Let me know your preference.
---
If your project is set up
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/12276#issuecomment-207865967
@holdenk
You made a good point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/12276#issuecomment-207852111
From SPARK-14462:
```
The test scope will still depend on spark-core and spark-core-test in order
to use the common utilities
```
If spark-core shouldn't
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/12276#issuecomment-207847901
@mengxr @dbtsai
Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user tedyu opened a pull request:
https://github.com/apache/spark/pull/12276
[SPARK-14462] [HOTFIX] Add dependency for Logging
## What changes were proposed in this pull request?
After [SPARK-14462] went in, build shows the following error:
```
[error
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12161#discussion_r59094076
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ColumnarAggMapCodeGenerator.scala
---
@@ -0,0 +1,193 @@
+/*
+ * Licensed
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/12225#issuecomment-206643680
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/12225#issuecomment-206643617
```
Building remotely on amp-jenkins-worker-08 (centos spark-test) in workspace
/home/jenkins/workspace/SparkPullRequestBuilder
...
fatal: cannot create
GitHub user tedyu opened a pull request:
https://github.com/apache/spark/pull/12225
SPARK-14448 Improvements to ColumnVector
## What changes were proposed in this pull request?
In this PR, two changes are proposed for ColumnVector :
1. ColumnVector should be declared
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12077#discussion_r58300711
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12108#discussion_r58295045
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/GenerateColumnAccessor.scala
---
@@ -114,6 +114,42 @@ object GenerateColumnAccessor
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12068#discussion_r58061293
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -524,6 +524,11 @@ object SQLConf {
doc = "The maximum n
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11943#issuecomment-203053830
Adding a space would make the line longer than 100 chars.
I suggest keeping the current form.
---
If your project is set up for it, you can reply to this email
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11943#issuecomment-203020773
@zsxwing
Is there anything that needs to be done for this PR ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11943#issuecomment-202466140
@davies @JoshRosen
Do you have any comment ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11943#issuecomment-202407877
@JnyJny
Did you have a chance to try out the change ?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11943#issuecomment-201035925
That's right, Ryan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11943#issuecomment-201020821
@JnyJny
Compilation error is fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11943#issuecomment-201010303
@zsxwing
Created this updated PR according to your suggestion on #10181.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user tedyu opened a pull request:
https://github.com/apache/spark/pull/11943
[SPARK-12181] Check Cached unaligned-access capability before using Unsafe
## What changes were proposed in this pull request?
For MemoryMode.OFF_HEAP, Unsafe.getInt etc. are used
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/10181#issuecomment-201004399
@zsxwing
Thanks for the pointer.
I will enhance Platform#unaligned() by referencing the code above.
---
If your project is set up for it, you can reply
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11709#discussion_r57014281
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -227,9 +276,19 @@ private void
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11826#discussion_r56918584
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoin.scala
---
@@ -55,11 +56,45 @@ case class ShuffledHashJoin
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11646#discussion_r56595063
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11664#discussion_r56221797
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -220,7 +221,47 @@ abstract class SparkPlan extends QueryPlan[SparkPlan
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11664#discussion_r56214366
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -220,7 +221,47 @@ abstract class SparkPlan extends QueryPlan[SparkPlan
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11664#discussion_r56214146
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -220,7 +221,47 @@ abstract class SparkPlan extends QueryPlan[SparkPlan
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11647#discussion_r56065435
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -152,7 +152,10 @@ abstract class Expression extends
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11455#discussion_r55873954
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -368,6 +368,30 @@ private[deploy] class Master
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11455#discussion_r55858792
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -368,6 +368,30 @@ private[deploy] class Master
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11586#discussion_r55731469
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -613,7 +613,12 @@ class DAGScheduler(
properties: Properties
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11586#discussion_r55634802
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -613,7 +613,12 @@ class DAGScheduler(
properties: Properties
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11444#discussion_r55449167
--- Diff: python/pyspark/sql/types.py ---
@@ -681,6 +681,129 @@ def __eq__(self, other):
for v in [ArrayType, MapType
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11509#discussion_r55372864
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala
---
@@ -1,265 +0,0 @@
-/*
- * Licensed to the Apache Software
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11509#discussion_r55318504
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -465,214 +379,165 @@ abstract class OutputWriter
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11420#issuecomment-189905340
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10705#discussion_r54321396
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala ---
@@ -0,0 +1,445 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52811398
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -328,7 +345,9 @@ final class ShuffleBlockFetcherIterator
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10838#discussion_r52811989
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -328,7 +345,9 @@ final class ShuffleBlockFetcherIterator
GitHub user tedyu opened a pull request:
https://github.com/apache/spark/pull/11161
Drop private for JobFailed
In the thread, 'SparkListener - why is org.apache.spark.scheduler.JobFailed
in scala private', Sumona was requesting JobFailed to be accessible by user
application
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11161#issuecomment-182624134
If this makes sense, I can create a JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user tedyu closed the pull request at:
https://github.com/apache/spark/pull/11161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11098#discussion_r52353770
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -516,7 +517,7 @@ private[spark] object Utils extends Logging
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-181874005
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user tedyu opened a pull request:
https://github.com/apache/spark/pull/11134
[SPARK-13203] Add scalastyle rule banning use of mutable.SynchronizedBuffer
@andrewor14
Please take a look
You can merge this pull request into a Git repository by running:
$ git pull
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11134#issuecomment-18226
@andrewor14
Is there anything I need to do for this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-181115720
It's nice of you to put related changes under one PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11066#issuecomment-180603069
From HiveContext.scala , line 552 (the last line below):
```
* 1. create a new SessionState for each HiveContext
* 2. when the Hive session is first
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11066#issuecomment-180583168
@davies
Can you take a look ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11066#issuecomment-180608746
The user was using 1.6.0 where there was no HiveClientImp.scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11066#issuecomment-179743176
Do you have suggestion on which class to put the common code in ?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11059#issuecomment-180046937
Should scalastyle rule be added to ban use of mutable.SynchronizedBuffer ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11066#issuecomment-180085647
I wonder if rev 1 should be used:
the utility class only saves less than 10 lines of code
intricacies were introduced w.r.t. class loading
---
If your
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11066#issuecomment-180183376
@hvanhovell
What do you think ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11066#issuecomment-180027386
This error surfaced:
```
[info] 2016-02-04 10:15:21.319 - stderr> Exception in thread "main"
java.lang.LinkageError: loader constraint violation: w
GitHub user tedyu opened a pull request:
https://github.com/apache/spark/pull/11061
Wrap HiveClientImpl#conf with withHiveState
See http://search-hadoop.com/m/q3RTtFoTDi2HVCrM1 for related stack trace
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user tedyu opened a pull request:
https://github.com/apache/spark/pull/11066
Protect against SessionState being null when accessing HiveClientImpl#conf
See http://search-hadoop.com/m/q3RTtFoTDi2HVCrM1 for related stack trace
You can merge this pull request into a Git
Github user tedyu closed the pull request at:
https://github.com/apache/spark/pull/11061
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11006#discussion_r51654597
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11006#discussion_r51654640
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11006#discussion_r51652148
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataStreamReader.scala ---
@@ -0,0 +1,127 @@
+/*
+* Licensed to the Apache Software Foundation
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/10995#issuecomment-178202908
This would still benefit Spark standalone and Spark on Mesos, right ?
For Spark on YARN, status quo is maintained.
---
If your project is set up for it, you can
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/10995#issuecomment-177266287
Would like some feedback before creating JIRA.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user tedyu opened a pull request:
https://github.com/apache/spark/pull/10995
[test-maven] Shade protobuf-java
See this thread for background information:
http://search-hadoop.com/m/q3RTtdkUFK11xQhP1/Spark+not+able+to+fetch+events+from+Amazon+Kinesis
This PR
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/9940#discussion_r51284828
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ---
@@ -359,6 +361,18 @@ object StructType extends AbstractDataType
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/9940#discussion_r51213506
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ---
@@ -359,6 +361,18 @@ object StructType extends AbstractDataType
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/9940#discussion_r51213703
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
---
@@ -258,7 +258,12 @@ private[sql] class
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/10931#issuecomment-175775287
Thanks for the reminder, Marcelo
I am wondering if jackson-annotations dependency is really needed.
---
If your project is set up for it, you can reply
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/10931#issuecomment-175789566
By dropping jackson-annotations dependency I was able to get compilation
pass.
If there is no objection, I can open another JIRA / PR for dropping
jackson
Github user tedyu closed the pull request at:
https://github.com/apache/spark/pull/10931
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/10931#issuecomment-175802692
Thanks for the pointer
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
101 - 200 of 503 matches
Mail list logo
