[GitHub] spark issue #17350: [SPARK-20017][SQL] change the nullability of function 'S...

2017-04-08 Thread zhaorongsheng
Github user zhaorongsheng commented on the issue: https://github.com/apache/spark/pull/17350 @gatorsmile Sorry for the late reply. I have checked all the functions' nullability setting and I didn't found any issue. Thanks~ --- If your project is set up for it, you can reply

[GitHub] spark issue #17350: [SPARK-20017][SQL] change the nullability of function 'S...

2017-03-21 Thread zhaorongsheng
Github user zhaorongsheng commented on the issue: https://github.com/apache/spark/pull/17350 @gatorsmile OK, I will do it and I will give you feedback as soon as possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark issue #17350: [SPARK-20017][SQL] change the nullability of function 'S...

2017-03-21 Thread zhaorongsheng
Github user zhaorongsheng commented on the issue: https://github.com/apache/spark/pull/17350 @gatorsmile Is it OK? I don't know how to add test case in string-function.sql. ï¼·ould you give me some guidance? Thanks~ --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #17350: [SPARK-20017][SQL] change the nullability of function 'S...

2017-03-20 Thread zhaorongsheng
Github user zhaorongsheng commented on the issue: https://github.com/apache/spark/pull/17350 @maropu The test case is added. Please check it, thanks~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request #17350: [SPARK-20017][SQL] change the nullability of func...

2017-03-19 Thread zhaorongsheng
GitHub user zhaorongsheng opened a pull request: https://github.com/apache/spark/pull/17350 [SPARK-20017][SQL] change the nullability of function 'StringToMap' from 'false' to 'true' ## What changes were proposed in this pull request? Change the nullability of function

[GitHub] spark pull request #14969: [SPARK-17406][WEB UI] limit timeline executor eve...

2017-01-23 Thread zhaorongsheng
Github user zhaorongsheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14969#discussion_r97465466 --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsTab.scala --- @@ -38,47 +37,67 @@ private[ui] class ExecutorsTab(parent: SparkUI

[GitHub] spark issue #16389: [SPARK-18981][Core]The job hang problem when speculation...

2017-01-23 Thread zhaorongsheng
Github user zhaorongsheng commented on the issue: https://github.com/apache/spark/pull/16389 @zsxwing @mridulm Would you check this PR please? Thanks~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16389: [SPARK-18981][Core]The job hang problem when speculation...

2016-12-30 Thread zhaorongsheng
Github user zhaorongsheng commented on the issue: https://github.com/apache/spark/pull/16389 @zsxwing I think it may cause some other problem. For example, if we got some ExecutorLostFailure and the speculated task was running on it, the `numRunningTasks` will never be zero

[GitHub] spark issue #16389: [SPARK-18981][Core]The job hang problem when speculation...

2016-12-28 Thread zhaorongsheng
Github user zhaorongsheng commented on the issue: https://github.com/apache/spark/pull/16389 Hi, is anyone can check this PR? thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #16389: [SPARK-18981][Core]The job hang problem when speculation...

2016-12-25 Thread zhaorongsheng
Github user zhaorongsheng commented on the issue: https://github.com/apache/spark/pull/16389 @mridulm Please check it. Thanks~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16389: [SPARK-18981][Core]The job hang problem when speculation...

2016-12-24 Thread zhaorongsheng
Github user zhaorongsheng commented on the issue: https://github.com/apache/spark/pull/16389 Yes, I have checked it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16389: [SPARK-18981][Core]The job hang problem when speculation...

2016-12-23 Thread zhaorongsheng
Github user zhaorongsheng commented on the issue: https://github.com/apache/spark/pull/16389 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16389: [SPARK-18981][Core]The job hang problem when speculation...

2016-12-23 Thread zhaorongsheng
Github user zhaorongsheng commented on the issue: https://github.com/apache/spark/pull/16389 Hi @mridulm . I have modified the tests. Please check it. Thanks~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #16394: [SPARK-18981][Core]The job hang problem when spec...

2016-12-23 Thread zhaorongsheng
Github user zhaorongsheng closed the pull request at: https://github.com/apache/spark/pull/16394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #16394: [SPARK-18981][Core]The job hang problem when spec...

2016-12-23 Thread zhaorongsheng
GitHub user zhaorongsheng opened a pull request: https://github.com/apache/spark/pull/16394 [SPARK-18981][Core]The job hang problem when speculation is on ## What changes were proposed in this pull request? The root cause of this issue is that `ExecutorAllocationListener

[GitHub] spark pull request #16389: [SPARK-18981][Core]The job hang problem when spec...

2016-12-23 Thread zhaorongsheng
Github user zhaorongsheng commented on a diff in the pull request: https://github.com/apache/spark/pull/16389#discussion_r93811187 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -938,6 +938,33 @@ class ExecutorAllocationManagerSuite

[GitHub] spark pull request #16389: [SPARK-18981][Core]The job hang problem when spec...

2016-12-23 Thread zhaorongsheng
GitHub user zhaorongsheng opened a pull request: https://github.com/apache/spark/pull/16389 [SPARK-18981][Core]The job hang problem when speculation is on ## What changes were proposed in this pull request? The root cause of this issue is that `ExecutorAllocationListener

[GitHub] spark pull request: update from orign

2016-05-15 Thread zhaorongsheng
Github user zhaorongsheng commented on the pull request: https://github.com/apache/spark/pull/13118#issuecomment-219288567 sorry, it is unintentional mistake. I close it right now! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: update from orign

2016-05-15 Thread zhaorongsheng
Github user zhaorongsheng closed the pull request at: https://github.com/apache/spark/pull/13118 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request: update from orign

2016-05-14 Thread zhaorongsheng
GitHub user zhaorongsheng opened a pull request: https://github.com/apache/spark/pull/13118 update from orign ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please