Gschiavon commented on issue #25728: [SPARK-29020][WIP][SQL] Improving
array_sort behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-53397
@ueshin @kiszk How can we move forward with it? I think there's only that
test missing, the rest is working and it is tested.
Gschiavon commented on issue #25728: [SPARK-29020][WIP][SQL] Improving
array_sort behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-538425396
No problem @kiszk .
Hmm I think is a different case. Im trying to do this:
` lazy val comparator: (Expression,
Gschiavon commented on issue #25728: [SPARK-29020][WIP][SQL] Improving
array_sort behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-537949568
ping @ueshin @kiszk
This is an automated message from the
Gschiavon commented on issue #25728: [SPARK-29020][WIP][SQL] Improving
array_sort behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-536013344
@kiszk This is my problem while making tests for the new signature.
I want to test `case class ArraySort(argument:
Gschiavon commented on issue #25728: [SPARK-29020][WIP][SQL] Improving
array_sort behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-535830980
Some of them yes @kiszk , but I was having some troubles with the tests.
I'll try to do them soon.
Gschiavon commented on issue #25728: [SPARK-29020][WIP][SQL] Improving
array_sort behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-532762883
I did this option
- remove `ArraySort` (and rename `ArraySorting` to `ArraySort`).
- add a new constructor which
Gschiavon commented on issue #25728: [SPARK-29020][WIP][SQL] Improving
array_sort behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-532071387
The problem here is the naming of the HOF array_sort.
In the `registry` we have this :
`
Gschiavon commented on issue #25728: [SPARK-29020][WIP][SQL] Improving
array_sort behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-531917056
@ueshin can you retest please? It was an import, it is fixed.
I also added a test for null values.
Gschiavon commented on issue #25728: [SPARK-29020][WIP][SQL] Improving
array_sort behaviour
URL: https://github.com/apache/spark/pull/25728#issuecomment-531593895
I've added some changes to add array_sort as HOF. I've followed
https://prestodb.github.io/docs/current/functions/array.html
