[GitHub] [spark] HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows

HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows URL: https://github.com/apache/spark/pull/26108#issuecomment-577441689 Btw, if we plan to have Spark 2.5 then makes sense to port back there (as e

[GitHub] [spark] HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows

HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows URL: https://github.com/apache/spark/pull/26108#issuecomment-577441221 https://issues.apache.org/jira/browse/SPARK-26154?focusedCommentId=17021627

[GitHub] [spark] HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows

HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows URL: https://github.com/apache/spark/pull/26108#issuecomment-577439743 OK I'll migrating my comments to JIRA issue as well. Thanks for guidance. -

[GitHub] [spark] HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows

HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows URL: https://github.com/apache/spark/pull/26108#issuecomment-577433981 So unlike other states having versions, for stream-stream outer join, there

[GitHub] [spark] HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows

HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows URL: https://github.com/apache/spark/pull/26108#issuecomment-577432819 > As written in the migration guide, the situation is the same in 3.0.0 with

[GitHub] [spark] HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows

HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows URL: https://github.com/apache/spark/pull/26108#issuecomment-577423338 We fixed the issue with "destructive way" on existing query as the state in

[GitHub] [spark] HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows

HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows URL: https://github.com/apache/spark/pull/26108#issuecomment-552690417 Thanks for reviewing and merging! -

[GitHub] [spark] HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows

HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows URL: https://github.com/apache/spark/pull/26108#issuecomment-552666483 Looks like no comment from others so far; shall we consider merging this? -

[GitHub] [spark] HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows

HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows URL: https://github.com/apache/spark/pull/26108#issuecomment-548140853 Could we go through the next round of review? Thanks in advance! --

[GitHub] [spark] HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows

HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows URL: https://github.com/apache/spark/pull/26108#issuecomment-546311307 Thanks again for reviewing! > Also, KeyWithIndexAndValueWithMatched i

[GitHub] [spark] HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows

HeartSaVioR commented on issue #26108: [SPARK-26154][SS] Streaming left/right outer join should not return outer nulls for already matched rows URL: https://github.com/apache/spark/pull/26108#issuecomment-541530948 cc. @tdas @zsxwing @jose-torres @gaborgsomogyi ---