[GitHub] [spark] HeartSaVioR commented on issue #26158: [SPARK-29509][SQL][SS] Deduplicate codes from Kafka data source

2019-10-28 Thread GitBox
HeartSaVioR commented on issue #26158: [SPARK-29509][SQL][SS] Deduplicate codes from Kafka data source URL: https://github.com/apache/spark/pull/26158#issuecomment-547102713 Thanks all for reviewing and merging! This is an

[GitHub] [spark] HeartSaVioR commented on issue #26158: [SPARK-29509][SQL][SS] Deduplicate codes from Kafka data source

2019-10-25 Thread GitBox
HeartSaVioR commented on issue #26158: [SPARK-29509][SQL][SS] Deduplicate codes from Kafka data source URL: https://github.com/apache/spark/pull/26158#issuecomment-546437641 Rebased. Please take a look at the next round of review. Thanks!

[GitHub] [spark] HeartSaVioR commented on issue #26158: [SPARK-29509][SQL][SS] Deduplicate codes from Kafka data source

2019-10-25 Thread GitBox
HeartSaVioR commented on issue #26158: [SPARK-29509][SQL][SS] Deduplicate codes from Kafka data source URL: https://github.com/apache/spark/pull/26158#issuecomment-546314267 I just spent more time to reduce more, as I saw more spots to deduplicate easily while addressing review comments.

[GitHub] [spark] HeartSaVioR commented on issue #26158: [SPARK-29509][SQL][SS] Deduplicate codes from Kafka data source

2019-10-18 Thread GitBox
HeartSaVioR commented on issue #26158: [SPARK-29509][SQL][SS] Deduplicate codes from Kafka data source URL: https://github.com/apache/spark/pull/26158#issuecomment-543737818 Thanks for the suggestion. Filed an issue and changed the title.