[GitHub] [spark] HeartSaVioR commented on pull request #38517: [SPARK-39591][SS] Async Progress Tracking

2022-12-19 Thread GitBox
HeartSaVioR commented on PR #38517: URL: https://github.com/apache/spark/pull/38517#issuecomment-1358951698 https://github.com/jerrypeng/spark/actions/runs/3737519049 Above build passed for the last commit

[GitHub] [spark] HeartSaVioR commented on pull request #38517: [SPARK-39591][SS] Async Progress Tracking

2022-12-19 Thread GitBox
HeartSaVioR commented on PR #38517: URL: https://github.com/apache/spark/pull/38517#issuecomment-1358900740 Let me give +1 once the builds are passed rather than waiting for addressing all minor/nit comments. We can deal with them as a follow-up PR. -- This is an automated message from

[GitHub] [spark] HeartSaVioR commented on pull request #38517: [SPARK-39591][SS] Async Progress Tracking

2022-12-19 Thread GitBox
HeartSaVioR commented on PR #38517: URL: https://github.com/apache/spark/pull/38517#issuecomment-1358899601 (You can ignore outdated comments since I messed up with only seeing two recent commits and maybe left some comments which only bound to old commit.) -- This is an automated

[GitHub] [spark] HeartSaVioR commented on pull request #38517: [SPARK-39591][SS] Async Progress Tracking

2022-12-16 Thread GitBox
HeartSaVioR commented on PR #38517: URL: https://github.com/apache/spark/pull/38517#issuecomment-1354530532 I'm not in favor of introducing change against normal microbatch execution. As I commented, it seems to me as high risk one. Instead of smooth transition for all cases, I'd say

[GitHub] [spark] HeartSaVioR commented on pull request #38517: [SPARK-39591][SS] Async Progress Tracking

2022-12-04 Thread GitBox
HeartSaVioR commented on PR #38517: URL: https://github.com/apache/spark/pull/38517#issuecomment-1336801690 Also cc. @mridulm since he reviewed the design doc in details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] HeartSaVioR commented on pull request #38517: [SPARK-39591][SS] Async Progress Tracking

2022-12-04 Thread GitBox
HeartSaVioR commented on PR #38517: URL: https://github.com/apache/spark/pull/38517#issuecomment-1336784998 cc. @zsxwing @viirya @xuanyuanking to seek a chance for getting help on reviewing. I'll look into the PR sooner as well. -- This is an automated message from the Apache Git