[GitHub] [spark] HeartSaVioR edited a comment on issue #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files

2019-08-22 Thread GitBox
HeartSaVioR edited a comment on issue #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files URL: https://github.com/apache/spark/pull/25488#issuecomment-524139791 Addressed. HADOOP JIRA issue is included in both code comment and PR description. Please take

[GitHub] [spark] HeartSaVioR edited a comment on issue #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files

2019-08-18 Thread GitBox
HeartSaVioR edited a comment on issue #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files URL: https://github.com/apache/spark/pull/25488#issuecomment-522379521 As the issue only occurs from temp file, another possible approach would be removing crc file

[GitHub] [spark] HeartSaVioR edited a comment on issue #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files

2019-08-18 Thread GitBox
HeartSaVioR edited a comment on issue #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files URL: https://github.com/apache/spark/pull/25488#issuecomment-522379521 Another possible approach would be removing crc file for temp file when FSOutputSummer is

[GitHub] [spark] HeartSaVioR edited a comment on issue #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files

2019-08-18 Thread GitBox
HeartSaVioR edited a comment on issue #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files URL: https://github.com/apache/spark/pull/25488#issuecomment-522379521 As the issue only occurs from temp file, another possible approach would be removing crc file

[GitHub] [spark] HeartSaVioR edited a comment on issue #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files

2019-08-18 Thread GitBox
HeartSaVioR edited a comment on issue #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files URL: https://github.com/apache/spark/pull/25488#issuecomment-522374487 And I'm not 100% sure of intention, but if we want to disable crc in below line, it doesn't

[GitHub] [spark] HeartSaVioR edited a comment on issue #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files

2019-08-18 Thread GitBox
HeartSaVioR edited a comment on issue #25488: [SPARK-28025][SS] Fix FileContextBasedCheckpointFileManager leaking crc files URL: https://github.com/apache/spark/pull/25488#issuecomment-522374487 And I'm not 100% sure of intention, but if we intended to disable crc via below line, it