[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571823610 Oh OK. I got the intention why the change was done like so, but still feel CREATE EXTERNAL TABLE

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571474000 > It's common to define the possible mistakes in the syntax rule ... I see. That totally

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571452747 The parts differentiating between two syntaxes are skewSpec, rowFormat, and createFileFormat

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571452747 The parts differentiate between two syntaxes are skewSpec, rowFormat, and createFileFormat

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571452747 The parts differentiate between two syntaxes are skewSpec, rowFormat, and createFileFormat

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571452747 The parts differentiate between two syntaxes are skewSpec, rowFormat, and createFileFormat

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571452747 The parts differentiate between two syntaxes are skewSpec, rowFormat, and createFileFormat

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571452747 The parts differentiate between two syntaxes are skewSpec, rowFormat, and createFileFormat

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571432884 The thing is that it "conditionally" works which is very confusing because the condition is

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571435159 IMHO, to avoid confusion, we may need to either differentiate visitCreateTable and

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571435159 IMHO, to avoid confusion, we may need to either differentiate createTable and createHiveTable at

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571432884 The thing is that it "conditionally" works which is very confusing because the condition is

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571432884 The thing is that it "conditionally" works which is very confusing because the condition is

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571432884 The thing is that it "conditionally" works which is very confusing because the condition is

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571146260 cc. @cloud-fan @gatorsmile , and @Ngone51 as SPARK-30098 made the change.

[GitHub] [spark] HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION

HeartSaVioR edited a comment on issue #27107: [SPARK-30436][SQL] Allow CREATE EXTERNAL TABLE with only requiring LOCATION URL: https://github.com/apache/spark/pull/27107#issuecomment-571132150 Btw, according to the javadoc on visitCreateHiveTable, it's described as "legacy syntax" and we