HyukjinKwon commented on a change in pull request #25113: [SPARK-28287][SQL][PYTHON][TESTS] Convert and port 'udaf.sql' into UDF test base URL: https://github.com/apache/spark/pull/25113#discussion_r304729414
########## File path: sql/core/src/test/resources/sql-tests/inputs/udf/udf-udaf.sql ########## @@ -0,0 +1,18 @@ +-- This test file was converted from udaf.sql. + +CREATE OR REPLACE TEMPORARY VIEW t1 AS SELECT * FROM VALUES +(1), (2), (3), (4) +as t1(int_col1); + +CREATE FUNCTION myDoubleAvg AS 'test.org.apache.spark.sql.MyDoubleAvg'; + +SELECT default.myDoubleAvg(udf(int_col1)) as my_avg from t1; Review comment: @vinodkc, let's add a different combination in general. For instance, ``` udf(default.myDoubleAvg(udf(int_col1))) ``` ``` udf(default.myDoubleAvg(int_col1)) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
