[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2021-11-24 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755910761 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@ pac

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2021-11-24 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755910761 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@ pac

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2021-11-24 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755839634 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@ pac

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2021-11-24 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755839634 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@ pac

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-28 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r496302219 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcConnectionProvider.scala ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Softw

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-27 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r495544499 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/JdbcConnectionProvider.scala ## @@ -0,0 +1,54 @@ +/*

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-27 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r495544534 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/JdbcConnectionProvider.scala ## @@ -0,0 +1,54 @@ +/*

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-27 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r495544381 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/JdbcConnectionProvider.scala ## @@ -0,0 +1,54 @@ +/*

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-27 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r495544433 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/JdbcConnectionProvider.scala ## @@ -0,0 +1,54 @@ +/*

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-27 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r495544081 ## File path: core/src/main/scala/org/apache/spark/security/SecurityConfigurationLock.scala ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-25 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r494878705 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala ## @@ -23,12 +23,15 @@ import java.util.{Loca

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

2020-09-25 Thread GitBox
HyukjinKwon commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r494878705 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala ## @@ -23,12 +23,15 @@ import java.util.{Loca