[GitHub] [spark] HyukjinKwon commented on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base

2019-07-18 Thread GitBox
HyukjinKwon commented on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25103#issuecomment-513074566 Merged to master. This is an

[GitHub] [spark] HyukjinKwon commented on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base

2019-07-18 Thread GitBox
HyukjinKwon commented on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25103#issuecomment-513059728 @huaxingao, can you update the diff comparing to the original file? Looks a bit weird. -

[GitHub] [spark] HyukjinKwon commented on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base

2019-07-17 Thread GitBox
HyukjinKwon commented on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25103#issuecomment-512658948 Looks good to me in general if the tests pass ---

[GitHub] [spark] HyukjinKwon commented on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base

2019-07-17 Thread GitBox
HyukjinKwon commented on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25103#issuecomment-512656194 retest this please This is a