HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-698117104
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-698136949
Thank you @zero323 for leading type hint support in PySpark.
This is an automated message from the Apache
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-698117104
Merged to master.
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-698117279
@zero323 mind working on:
- writing the guidelines in the doc
- removing non-API type hints
?
I think these two are pretty important followups to be done soon ..
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-697303691
I'm going to merge if there's no more comment tomorrow.
This is an automated message from the Apache Git
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-697183521
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-697051612
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-697052814
@zero323, sorry I caused a bit of conflicts. Once it's resolved, let's just
merge and go ahead.
I think there's not much point of leaving it open and blocking the works.
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-697051612
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-693304997
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-693147207
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-690930268
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-690930268
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-690930268
Will take a look too @zero323 within few days. Thanks for doing this.
This is an automated message from the
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-688561042
cc @BryanCutler, @viirya, @ueshin, @Fokko, @holdenk can you review this when
you guys fine some time?
FYI:
We'll probably try to expose the type hints for
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-687956805
@zero323, I usually prefer to don't block something by the env issue in
Jenkins so such issue can be handled with enough time - @shaneknapp is sort of
busy at this moment
HyukjinKwon commented on pull request #29591:
URL: https://github.com/apache/spark/pull/29591#issuecomment-683593190
Let's use SPARK-32714 for this initial port, and use SPARK-32681 as an
umbrella ticket to add other related tickets for followup works.
17 matches
Mail list logo
