HyukjinKwon opened a new pull request #28589:
URL: https://github.com/apache/spark/pull/28589


   ### What changes were proposed in this pull request?
   
   This PR proposes to only allow the import of `ResourceInformation` as below:
   
   ```
   pyspark.resource.ResourceInformation
   ```
   
   instead of 
   
   ```
   pyspark.ResourceInformation
   pyspark.resource.ResourceInformation
   ```
   
   because `pyspark.resource` is a separate module, and it is documented so.
   The constructor of `ResourceInformation` isn't supposed to directly call 
anyway.
   
   
   ### Why are the changes needed?
   
   To keep the code structure coherent.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, it will be in the unreleased branches.
   
   ### How was this patch tested?
   
   Manually tested via importing:
   
   Before:
   
   ```python
   >>> import pyspark
   >>> pyspark.ResourceInformation
   <class 'pyspark.resource.information.ResourceInformation'>
   >>> pyspark.resource.ResourceInformation
   <class 'pyspark.resource.information.ResourceInformation'>
   ```
   
   After:
   
   ```python
   >>> import pyspark
   >>> pyspark.ResourceInformation
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
   AttributeError: module 'pyspark' has no attribute 'ResourceInformation'
   >>> pyspark.resource.ResourceInformation
   <class 'pyspark.resource.information.ResourceInformation'>
   ```
   
   Jenkins will test and existing tests should cover.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to