[GitHub] [spark] LuciferYang commented on a diff in pull request #39555: [SPARK-42051][SQL] Codegen Support for HiveGenericUDF

2023-01-22 Thread via GitHub
LuciferYang commented on code in PR #39555: URL: https://github.com/apache/spark/pull/39555#discussion_r1083687701 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -192,6 +194,48 @@ private[hive] case class HiveGenericUDF( override protected def wi

[GitHub] [spark] LuciferYang commented on a diff in pull request #39555: [SPARK-42051][SQL] Codegen Support for HiveGenericUDF

2023-01-22 Thread via GitHub
LuciferYang commented on code in PR #39555: URL: https://github.com/apache/spark/pull/39555#discussion_r1083674070 ## sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala: ## @@ -154,17 +154,19 @@ private[hive] case class HiveGenericUDF( function.initializeAndFo