LuciferYang commented on code in PR #41473: URL: https://github.com/apache/spark/pull/41473#discussion_r1218954958
########## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/CheckConnectJvmClientCompatibility.scala: ########## @@ -95,7 +95,7 @@ object CheckConnectJvmClientCompatibility { } catch { case e: Throwable => println(e.getMessage) - resultWriter.write(s"ERROR: ${e.getMessage}") + resultWriter.write(s"ERROR: ${e.getMessage}\n") Review Comment: @dongjoon-hyun Thanks for your review. Good question. Due to Spark 3.4.x will not add new modules for mima check with connect module, this issue should not be triggered, so I think just fixing it in Spark 3.5.0 is enough now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org