[GitHub] [spark] MaxGekk commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-06-01 Thread GitBox
MaxGekk commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r886901736 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala: ## @@ -319,7 +320,8 @@ abstract class StreamExecution( // This is a

[GitHub] [spark] MaxGekk commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-06-01 Thread GitBox
MaxGekk commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r886633465 ## connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala: ## @@ -1376,6 +1376,13 @@ class KafkaMicroBatchV1SourceSuite

[GitHub] [spark] MaxGekk commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-05-31 Thread GitBox
MaxGekk commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r885955542 ## connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala: ## @@ -666,10 +669,7 @@ abstract class

[GitHub] [spark] MaxGekk commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-05-31 Thread GitBox
MaxGekk commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r885953095 ## sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala: ## @@ -486,4 +489,22 @@ object QueryExecution { val preparationRules =

[GitHub] [spark] MaxGekk commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-05-31 Thread GitBox
MaxGekk commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r885944596 ## connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala: ## @@ -1376,6 +1376,13 @@ class KafkaMicroBatchV1SourceSuite

[GitHub] [spark] MaxGekk commented on a diff in pull request #36704: [SPARK-39346][SQL] Convert asserts/illegal state exception to internal errors on each phase

2022-05-31 Thread GitBox
MaxGekk commented on code in PR #36704: URL: https://github.com/apache/spark/pull/36704#discussion_r885936568 ## sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala: ## @@ -486,4 +489,22 @@ object QueryExecution { val preparationRules =