[GitHub] [spark] MaxGekk commented on issue #25772: [SPARK-29065][SQL][TEST] Extend `EXTRACT` benchmark

2019-09-12 Thread GitBox
MaxGekk commented on issue #25772: [SPARK-29065][SQL][TEST] Extend `EXTRACT` benchmark URL: https://github.com/apache/spark/pull/25772#issuecomment-530736239 @maropu @dongjoon-hyun @cloud-fan Thank you for your quick feedback. I reverted changes in `Cast`, and did conversion to `DATE` via

[GitHub] [spark] MaxGekk commented on issue #25772: [SPARK-29065][SQL][TEST] Extend `EXTRACT` benchmark

2019-09-12 Thread GitBox
MaxGekk commented on issue #25772: [SPARK-29065][SQL][TEST] Extend `EXTRACT` benchmark URL: https://github.com/apache/spark/pull/25772#issuecomment-530696202 @dongjoon-hyun @cloud-fan @maropu Could you take a look at the PR. Should I extract cast-related code to a separate PR? WDYT? -