[GitHub] [spark] NarekDW commented on pull request #39501: [SPARK-41295][SPARK-41296][SQL] Rename the error classes

2023-02-02 Thread via GitHub
NarekDW commented on PR #39501: URL: https://github.com/apache/spark/pull/39501#issuecomment-1413619148 > All those errors are compilation-wise errors. Please, move tests to `QueryCompilationErrorsSuite`. Done. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] NarekDW commented on pull request #39501: [SPARK-41295][SPARK-41296][SQL] Rename the error classes

2023-02-01 Thread via GitHub
NarekDW commented on PR #39501: URL: https://github.com/apache/spark/pull/39501#issuecomment-1411828618 @MaxGekk by the way, don't we need to move these functions from `org.apache.spark.sql.errors.QueryCompilationErrors` to `org.apache.spark.sql.errors.QueryExecutionErrors` ? From my poi

[GitHub] [spark] NarekDW commented on pull request #39501: [SPARK-41295][SPARK-41296][SQL] Rename the error classes

2023-01-23 Thread via GitHub
NarekDW commented on PR #39501: URL: https://github.com/apache/spark/pull/39501#issuecomment-1400327098 > @itholic do they want to use the email and name in their Github profile? Hi @srowen yep, that would be fine. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] NarekDW commented on pull request #39501: [SPARK-41295][SPARK-41296][SQL] Rename the error classes

2023-01-22 Thread via GitHub
NarekDW commented on PR #39501: URL: https://github.com/apache/spark/pull/39501#issuecomment-1399605596 > Cool, thanks!! > > BTW, if you happen to interested in more contribution to rename error class, could you try resolving [SPARK-41302](https://issues.apache.org/jira/browse/SPARK-

[GitHub] [spark] NarekDW commented on pull request #39501: [SPARK-41295][SPARK-41296][SQL] Rename the error classes

2023-01-22 Thread via GitHub
NarekDW commented on PR #39501: URL: https://github.com/apache/spark/pull/39501#issuecomment-1399593726 > Sure, done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.