[GitHub] [spark] Peng-Lei commented on a change in pull request #35204: [SPARK-37878][SQL] Migrate SHOW CREATE TABLE to use v2 command by default

2022-01-17 Thread GitBox
Peng-Lei commented on a change in pull request #35204: URL: https://github.com/apache/spark/pull/35204#discussion_r785729941 ## File path: sql/core/src/test/resources/sql-tests/results/show-create-table.sql.out ## @@ -257,7 +257,7 @@ SHOW CREATE TABLE tbl -- !query schema

[GitHub] [spark] Peng-Lei commented on a change in pull request #35204: [SPARK-37878][SQL] Migrate SHOW CREATE TABLE to use v2 command by default

2022-01-17 Thread GitBox
Peng-Lei commented on a change in pull request #35204: URL: https://github.com/apache/spark/pull/35204#discussion_r785723741 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowCreateTableExec.scala ## @@ -98,11 +126,11 @@ case class

[GitHub] [spark] Peng-Lei commented on a change in pull request #35204: [SPARK-37878][SQL] Migrate SHOW CREATE TABLE to use v2 command by default

2022-01-16 Thread GitBox
Peng-Lei commented on a change in pull request #35204: URL: https://github.com/apache/spark/pull/35204#discussion_r785703083 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/V1Table.scala ## @@ -58,7 +59,7 @@ private[sql] case class

[GitHub] [spark] Peng-Lei commented on a change in pull request #35204: [SPARK-37878][SQL] Migrate SHOW CREATE TABLE to use v2 command by default

2022-01-16 Thread GitBox
Peng-Lei commented on a change in pull request #35204: URL: https://github.com/apache/spark/pull/35204#discussion_r785698864 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowCreateTableExec.scala ## @@ -98,11 +126,11 @@ case class

[GitHub] [spark] Peng-Lei commented on a change in pull request #35204: [SPARK-37878][SQL] Migrate SHOW CREATE TABLE to use v2 command by default

2022-01-13 Thread GitBox
Peng-Lei commented on a change in pull request #35204: URL: https://github.com/apache/spark/pull/35204#discussion_r784626408 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -1054,6 +1054,15 @@ trait ShowCreateTableCommandBase {

[GitHub] [spark] Peng-Lei commented on a change in pull request #35204: [SPARK-37878][SQL] Migrate SHOW CREATE TABLE to use v2 command by default

2022-01-13 Thread GitBox
Peng-Lei commented on a change in pull request #35204: URL: https://github.com/apache/spark/pull/35204#discussion_r784521194 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -266,12 +266,15 @@ class

[GitHub] [spark] Peng-Lei commented on a change in pull request #35204: [SPARK-37878][SQL] Migrate SHOW CREATE TABLE to use v2 command by default

2022-01-13 Thread GitBox
Peng-Lei commented on a change in pull request #35204: URL: https://github.com/apache/spark/pull/35204#discussion_r784520723 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/V1Table.scala ## @@ -58,7 +59,7 @@ private[sql] case class

[GitHub] [spark] Peng-Lei commented on a change in pull request #35204: [SPARK-37878][SQL] Migrate SHOW CREATE TABLE to use v2 command by default

2022-01-13 Thread GitBox
Peng-Lei commented on a change in pull request #35204: URL: https://github.com/apache/spark/pull/35204#discussion_r784509866 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/V1Table.scala ## @@ -58,7 +59,7 @@ private[sql] case class