[GitHub] [spark] WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC

2019-06-29 Thread GitBox
WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC URL: https://github.com/apache/spark/pull/24043#issuecomment-507001560 > @WangGuangxin Could you submit a follow-up PR for updating the document? See the example

[GitHub] [spark] WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC

2019-06-29 Thread GitBox
WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC URL: https://github.com/apache/spark/pull/24043#issuecomment-507001494 > Thanks for your work @WangGuangxin ! > > What is your JIRA account? We need to assign the assignee field to your JIRA

[GitHub] [spark] WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC

2019-06-27 Thread GitBox
WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC URL: https://github.com/apache/spark/pull/24043#issuecomment-506605111 > Retest it please @gengliangwang Could you please make jenkins retest this? Thanks

[GitHub] [spark] WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC

2019-06-26 Thread GitBox
WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC URL: https://github.com/apache/spark/pull/24043#issuecomment-505749196 Retest it please This is an automated message from the Apache Git

[GitHub] [spark] WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC

2019-06-25 Thread GitBox
WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC URL: https://github.com/apache/spark/pull/24043#issuecomment-505696784 > The test failure looks legitimate. > > @gengliangwang @dongjoon-hyun Please review the test cases? This test case

[GitHub] [spark] WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC

2019-06-22 Thread GitBox
WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC URL: https://github.com/apache/spark/pull/24043#issuecomment-504642717 > LGTM except one comment Thanks. cc @dongjoon-hyun @gatorsmile

[GitHub] [spark] WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC

2019-06-09 Thread GitBox
WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC URL: https://github.com/apache/spark/pull/24043#issuecomment-500217151 Sorry for late response. I've made change accordingly. Retest this please

[GitHub] [spark] WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC

2019-05-27 Thread GitBox
WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC URL: https://github.com/apache/spark/pull/24043#issuecomment-496338467 kindly ping @dongjoon-hyun This is an automated message from the

[GitHub] [spark] WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC

2019-05-21 Thread GitBox
WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC URL: https://github.com/apache/spark/pull/24043#issuecomment-494662341 The build failure was because the type of `option` has been changed in lastest master. Fixed by rebase with master. Retest

[GitHub] [spark] WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC

2019-05-21 Thread GitBox
WangGuangxin commented on issue #24043: [SPARK-11412][SQL] Support merge schema for ORC URL: https://github.com/apache/spark/pull/24043#issuecomment-494632040 @dongjoon-hyun Thanks for your review. I've updated it according to your comments.

[GitHub] [spark] WangGuangxin commented on issue #24043: [SPARK-11412][SQL]Support merge schema for ORC

2019-03-12 Thread GitBox
WangGuangxin commented on issue #24043: [SPARK-11412][SQL]Support merge schema for ORC URL: https://github.com/apache/spark/pull/24043#issuecomment-471968126 @dongjoon-hyun Could you please review this PR? This is an