[GitHub] [spark] Yikun commented on pull request #32867: [SPARK-35721][PYTHON] Path level discover for python unittests

2021-07-01 Thread GitBox
Yikun commented on pull request #32867: URL: https://github.com/apache/spark/pull/32867#issuecomment-872072514 The root reason of failed to discover is that the deps of PySpark modules is not installed, so we get the wrong list when we do discover. I re-propose it in

[GitHub] [spark] Yikun commented on pull request #32867: [SPARK-35721][PYTHON] Path level discover for python unittests

2021-06-29 Thread GitBox
Yikun commented on pull request #32867: URL: https://github.com/apache/spark/pull/32867#issuecomment-871032645 Thanks for revert for it. I'm so sorry for the trouble, I will recheck and fix soon. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] Yikun commented on pull request #32867: [SPARK-35721][PYTHON] Path level discover for python unittests

2021-06-29 Thread GitBox
Yikun commented on pull request #32867: URL: https://github.com/apache/spark/pull/32867#issuecomment-870221373 > Just wondering we can only verify it manually? If by any chance, some tests are not found, can we easily know it? It just same as before, if we forgot to add the path of

[GitHub] [spark] Yikun commented on pull request #32867: [SPARK-35721][PYTHON] Path level discover for python unittests

2021-06-28 Thread GitBox
Yikun commented on pull request #32867: URL: https://github.com/apache/spark/pull/32867#issuecomment-870221373 > Just wondering we can only verify it manually? If by any chance, some tests are not found, can we easily know it? It just same as before, if we forgot to add the path of

[GitHub] [spark] Yikun commented on pull request #32867: [SPARK-35721][PYTHON] Path level discover for python unittests

2021-06-28 Thread GitBox
Yikun commented on pull request #32867: URL: https://github.com/apache/spark/pull/32867#issuecomment-869430292 > BTW, this change will likely affect many other vendors who maintain their forks so I will take a close look few more times. Thanks for bearing with me in advance .. ;-).

[GitHub] [spark] Yikun commented on pull request #32867: [SPARK-35721][PYTHON] Path level discover for python unittests

2021-06-25 Thread GitBox
Yikun commented on pull request #32867: URL: https://github.com/apache/spark/pull/32867#issuecomment-868934485 @HyukjinKwon Ready for review, it would be good if you could take a look again. : ) -- This is an automated message from the Apache Git Service. To respond to the message,