[GitHub] [spark] advancedxy commented on a diff in pull request #41192: [SPARK-43530][PROTOBUF] Read descriptor file only once

2023-05-18 Thread via GitHub
advancedxy commented on code in PR #41192: URL: https://github.com/apache/spark/pull/41192#discussion_r1198495651 ## connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/CatalystDataToProtobuf.scala: ## @@ -26,14 +26,14 @@ import org.apache.spark.sql.types.{BinaryType

[GitHub] [spark] advancedxy commented on a diff in pull request #41192: [SPARK-43530][PROTOBUF] Read descriptor file only once

2023-05-18 Thread via GitHub
advancedxy commented on code in PR #41192: URL: https://github.com/apache/spark/pull/41192#discussion_r1198495651 ## connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/CatalystDataToProtobuf.scala: ## @@ -26,14 +26,14 @@ import org.apache.spark.sql.types.{BinaryType

[GitHub] [spark] advancedxy commented on a diff in pull request #41192: [SPARK-43530][PROTOBUF] Read descriptor file only once

2023-05-17 Thread via GitHub
advancedxy commented on code in PR #41192: URL: https://github.com/apache/spark/pull/41192#discussion_r1197287073 ## connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/CatalystDataToProtobuf.scala: ## @@ -26,14 +26,14 @@ import org.apache.spark.sql.types.{BinaryType