[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-15 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470892621 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,53 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-14 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470873077 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +85,215 @@ case class

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470263293 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator()

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470248197 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,62 @@ public MapIterator destructiveIterator()

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470229887 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +85,210 @@ case class

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470211909 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,53 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-13 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470091083 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -601,6 +657,14 @@ public boolean isDefined() {

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-10 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r467709017 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,53 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-09 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r467667250 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,42 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-08 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r467372338 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1188,4 +1188,42 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-06 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r466738015 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala ## @@ -71,8 +89,134 @@ case class

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-06 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r466556531 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -76,6 +76,11 @@ private[execution] sealed

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-06 Thread GitBox
agrawaldevesh commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r466533520 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -314,7 +338,9 @@ private[joins] object