[GitHub] [spark] agubichev commented on a diff in pull request #42778: [SPARK-45055] [SQL] Do not transpose windows if they conflict on ORDER BY / PROJECT clauses

2023-09-05 Thread via GitHub
agubichev commented on code in PR #42778: URL: https://github.com/apache/spark/pull/42778#discussion_r1316176643 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/TransposeWindowSuite.scala: ## @@ -160,4 +160,18 @@ class TransposeWindowSuite extends PlanTest

[GitHub] [spark] agubichev commented on a diff in pull request #42778: [SPARK-45055] [SQL] Do not transpose windows if they conflict on ORDER BY / PROJECT clauses

2023-09-04 Thread via GitHub
agubichev commented on code in PR #42778: URL: https://github.com/apache/spark/pull/42778#discussion_r1315214615 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -1305,11 +1305,20 @@ object TransposeWindow extends Rule[LogicalPlan] {

[GitHub] [spark] agubichev commented on a diff in pull request #42778: [SPARK-45055] [SQL] Do not transpose windows if they conflict on ORDER BY / PROJECT clauses

2023-09-04 Thread via GitHub
agubichev commented on code in PR #42778: URL: https://github.com/apache/spark/pull/42778#discussion_r1315214615 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -1305,11 +1305,20 @@ object TransposeWindow extends Rule[LogicalPlan] {

[GitHub] [spark] agubichev commented on a diff in pull request #42778: [SPARK-45055] [SQL] Do not transpose windows if they conflict on ORDER BY / PROJECT clauses

2023-09-04 Thread via GitHub
agubichev commented on code in PR #42778: URL: https://github.com/apache/spark/pull/42778#discussion_r1315214615 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -1305,11 +1305,20 @@ object TransposeWindow extends Rule[LogicalPlan] {