[GitHub] [spark] amaliujia commented on a diff in pull request #38659: [SPARK-41114][CONNECT] Support local data for LocalRelation

2022-11-22 Thread GitBox
amaliujia commented on code in PR #38659: URL: https://github.com/apache/spark/pull/38659#discussion_r1030009940 ## connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -271,8 +273,12 @@ class SparkConnectPlanner(session:

[GitHub] [spark] amaliujia commented on a diff in pull request #38659: [SPARK-41114][CONNECT] Support local data for LocalRelation

2022-11-16 Thread GitBox
amaliujia commented on code in PR #38659: URL: https://github.com/apache/spark/pull/38659#discussion_r1024759018 ## connector/connect/src/main/protobuf/spark/connect/relations.proto: ## @@ -213,7 +213,7 @@ message Deduplicate { message LocalRelation { repeated

[GitHub] [spark] amaliujia commented on a diff in pull request #38659: [SPARK-41114][CONNECT] Support local data for LocalRelation

2022-11-16 Thread GitBox
amaliujia commented on code in PR #38659: URL: https://github.com/apache/spark/pull/38659#discussion_r1024749559 ## connector/connect/src/main/protobuf/spark/connect/relations.proto: ## @@ -213,7 +213,7 @@ message Deduplicate { message LocalRelation { repeated