[GitHub] [spark] amaliujia commented on pull request #37994: [SPARK-40454][CONNECT] Initial DSL framework for protobuf testing

2022-10-10 Thread GitBox
amaliujia commented on PR #37994: URL: https://github.com/apache/spark/pull/37994#issuecomment-1274024522 @HyukjinKwon yeah let me think about it... with this DSL framework at least we have increased the probability for reusing existing tests. -- This is an automated message from

[GitHub] [spark] amaliujia commented on pull request #37994: [SPARK-40454][CONNECT] Initial DSL framework for protobuf testing

2022-10-06 Thread GitBox
amaliujia commented on PR #37994: URL: https://github.com/apache/spark/pull/37994#issuecomment-1270888444 Here is the build job for my last commit and all test should have passed: https://github.com/amaliujia/spark/actions/runs/3200321726 -- This is an automated message from the Apache

[GitHub] [spark] amaliujia commented on pull request #37994: [SPARK-40454][CONNECT] Initial DSL framework for protobuf testing

2022-10-06 Thread GitBox
amaliujia commented on PR #37994: URL: https://github.com/apache/spark/pull/37994#issuecomment-1270510395 the maven build should have worked but I don't know why the SBT build has an issue. Taking a look. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] amaliujia commented on pull request #37994: [SPARK-40454][Connect]Initial DSL framework for protobuf testing

2022-09-25 Thread GitBox
amaliujia commented on PR #37994: URL: https://github.com/apache/spark/pull/37994#issuecomment-1257516316 @cloud-fan @HyukjinKwon @@grundprinzip -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to