[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-559653992 @maropu Please check latest changes. Thanks This is an

[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-558737460 Yes. I will merge these two rules that are, `CastToTimestamp` and `CastToBoolean`

[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-558470761 @Ngone51 I have updated this PR as per your reviews. Kindly review. cc @maropu @cloud-fan

[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-557985941 cc @maropu @Ngone51 This is an automated message from the

[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-557380239 @Ngone51 can you review this PR? This is an automated

[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-556984537 Jenkins, test this please. This is an automated message from

[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-555836497 @maropu Kindly review this. This is an automated message

[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-555357983 cc @cloud-fan This is an automated message from the Apache

[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-554816305 cc @maropu This is an automated message from the Apache Git

[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-554404054 @maropu Kindly review. I have updated as per your suggestion.

[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-554358640 @maropu Can you review the latest changes? This is an

[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-554201747 @maropu updated as per review comments. `withTimeZone()` is being repeated because cannot override it in abstract class

[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-553866227 cc @maropu @cloud-fan This is an automated message from the

[GitHub] [spark] amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp

amanomer commented on issue #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#issuecomment-553733796 Retest this please This is an automated message from the