[GitHub] [spark] beliefer commented on a diff in pull request #40277: [SPARK-42555][CONNECT][FOLLOWUP] Add the new proto msg to support the remaining jdbc API

2023-03-06 Thread via GitHub
beliefer commented on code in PR #40277: URL: https://github.com/apache/spark/pull/40277#discussion_r1127311861 ## connector/connect/common/src/main/protobuf/spark/connect/relations.proto: ## @@ -140,6 +140,9 @@ message Read { // (Optional) A list of path for file-system

[GitHub] [spark] beliefer commented on a diff in pull request #40277: [SPARK-42555][CONNECT][FOLLOWUP] Add the new proto msg to support the remaining jdbc API

2023-03-06 Thread via GitHub
beliefer commented on code in PR #40277: URL: https://github.com/apache/spark/pull/40277#discussion_r1127291008 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/DataFrameReader.scala: ## @@ -250,6 +250,46 @@ class DataFrameReader private[sql] (sparkSession:

[GitHub] [spark] beliefer commented on a diff in pull request #40277: [SPARK-42555][CONNECT][FOLLOWUP] Add the new proto msg to support the remaining jdbc API

2023-03-06 Thread via GitHub
beliefer commented on code in PR #40277: URL: https://github.com/apache/spark/pull/40277#discussion_r1126210535 ## connector/connect/common/src/main/protobuf/spark/connect/relations.proto: ## @@ -140,6 +141,21 @@ message Read { // (Optional) A list of path for file-system

[GitHub] [spark] beliefer commented on a diff in pull request #40277: [SPARK-42555][CONNECT][FOLLOWUP] Add the new proto msg to support the remaining jdbc API

2023-03-05 Thread via GitHub
beliefer commented on code in PR #40277: URL: https://github.com/apache/spark/pull/40277#discussion_r1125854126 ## connector/connect/common/src/main/protobuf/spark/connect/relations.proto: ## @@ -140,6 +141,21 @@ message Read { // (Optional) A list of path for file-system