[GitHub] [spark] beliefer commented on pull request #37825: [SPARK-40382][SQL] Group distinct aggregate expressions by semantically equivalent children in `RewriteDistinctAggregates`

2022-09-26 Thread GitBox
beliefer commented on PR #37825: URL: https://github.com/apache/spark/pull/37825#issuecomment-1258944783 > Thanks, I will take a look. This is reference to the fall-through case, where we discover there is really only a single distinct group, correct? Yes. `distinct b + 1` and

[GitHub] [spark] beliefer commented on pull request #37825: [SPARK-40382][SQL] Group distinct aggregate expressions by semantically equivalent children in `RewriteDistinctAggregates`

2022-09-25 Thread GitBox
beliefer commented on PR #37825: URL: https://github.com/apache/spark/pull/37825#issuecomment-1257447790 It seems a little complex. I have an idea to simplify the binary expressions in other optimizer rule. Please reference `SimplifyBinaryComparison`. -- This is an automated