[GitHub] [spark] brkyvz commented on a change in pull request #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2

2020-11-17 Thread GitBox
brkyvz commented on a change in pull request #28027: URL: https://github.com/apache/spark/pull/28027#discussion_r525389190 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsMetadataColumns.java ## @@ -0,0 +1,29 @@ +package

[GitHub] [spark] brkyvz commented on a change in pull request #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2

2020-10-27 Thread GitBox
brkyvz commented on a change in pull request #28027: URL: https://github.com/apache/spark/pull/28027#discussion_r512996706 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala ## @@ -48,6 +48,15 @@ case class

[GitHub] [spark] brkyvz commented on a change in pull request #28027: [SPARK-31255][SQL] Add SupportsMetadataColumns to DSv2

2020-10-26 Thread GitBox
brkyvz commented on a change in pull request #28027: URL: https://github.com/apache/spark/pull/28027#discussion_r512364187 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ## @@ -880,6 +880,12 @@ case class