[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-07-31 Thread GitBox
cloud-fan commented on a change in pull request #27507: URL: https://github.com/apache/spark/pull/27507#discussion_r463511408 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.scala ## @@ -322,6 +322,48 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #27507: URL: https://github.com/apache/spark/pull/27507#discussion_r463385548 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.scala ## @@ -322,6 +322,48 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #27507: URL: https://github.com/apache/spark/pull/27507#discussion_r463001372 ## File path: sql/core/src/test/resources/sql-tests/inputs/regexp-functions.sql ## @@ -8,4 +8,16 @@ SELECT regexp_extract('1a 2b 14m',

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #27507: URL: https://github.com/apache/spark/pull/27507#discussion_r463000941 ## File path: sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala ## @@ -154,8 +154,38 @@ class StringFunctionsSuite extends

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #27507: URL: https://github.com/apache/spark/pull/27507#discussion_r462999810 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.scala ## @@ -322,6 +322,48 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #27507: URL: https://github.com/apache/spark/pull/27507#discussion_r462997365 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -2486,6 +2488,19 @@ object functions { RegExpExtract(e.expr,

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #27507: URL: https://github.com/apache/spark/pull/27507#discussion_r462994993 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -518,3 +546,106 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #27507: URL: https://github.com/apache/spark/pull/27507#discussion_r462994150 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -492,7 +521,6 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #27507: URL: https://github.com/apache/spark/pull/27507#discussion_r462994468 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -518,3 +546,106 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #27507: URL: https://github.com/apache/spark/pull/27507#discussion_r462993825 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -421,20 +423,59 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #27507: URL: https://github.com/apache/spark/pull/27507#discussion_r462993465 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -421,20 +423,59 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-07-30 Thread GitBox
cloud-fan commented on a change in pull request #27507: URL: https://github.com/apache/spark/pull/27507#discussion_r462991248 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ## @@ -421,20 +423,59 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-13 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378857718 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-13 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378858627 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-13 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378857718 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-13 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378856977 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378416827 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378416104 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378292496 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378241896 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378240497 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378240309 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378238116 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378238116 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378238116 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378239103 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378239327 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378238547 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378238397 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378238116 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-12 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r378237273 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-11 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r377613299 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all

2020-02-11 Thread GitBox
cloud-fan commented on a change in pull request #27507: [SPARK-24884][SQL] Support regexp function regexp_extract_all URL: https://github.com/apache/spark/pull/27507#discussion_r377613558 ## File path: