[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480963443 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1326,24 +1326,49 @@ class Analyzer( *

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480961849 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1326,24 +1326,49 @@ class Analyzer( *

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480960791 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1326,24 +1326,49 @@ class Analyzer( *

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480856230 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1325,24 +1325,43 @@ class Analyzer( *

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480855693 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1325,24 +1325,43 @@ class Analyzer( *

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480853788 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1325,24 +1325,43 @@ class Analyzer( *

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480853788 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1325,24 +1325,43 @@ class Analyzer( *

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480851973 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1325,24 +1325,43 @@ class Analyzer( *

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480848629 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1325,24 +1325,43 @@ class Analyzer( *

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480805872 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1425,11 +1433,48 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480801106 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1326,7 +1326,11 @@ class Analyzer( * Note

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480801309 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1425,11 +1433,48 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480799758 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1428,8 +1428,36 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480799325 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1326,7 +1326,11 @@ class Analyzer( * Note

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480265324 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1425,11 +1436,33 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480202463 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1583,6 +1611,35 @@ class Analyzer(

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480201905 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1583,6 +1611,35 @@ class Analyzer(

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480200524 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1583,6 +1611,35 @@ class Analyzer(

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480199677 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1428,8 +1428,36 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480200056 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1428,8 +1428,36 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480172364 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1428,8 +1428,46 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480171470 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1428,8 +1428,46 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480148059 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1428,8 +1428,46 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480122040 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,42 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480121736 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3383,6 +3419,25 @@ object CleanupAliases

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480121375 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,42 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r480121157 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,42 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r479961994 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -570,18 +570,44 @@ class Analyzer(

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r479953325 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -570,18 +570,44 @@ class Analyzer(

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r479953325 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -570,18 +570,44 @@ class Analyzer(

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r479932237 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3496,6 +3496,98 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r471496799 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,33 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r471409620 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,33 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r470635433 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,33 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r470522985 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,33 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r470523167 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,33 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r470508893 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,33 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r469923244 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,33 @@ class Analyzer( //