[GitHub] [spark] cloud-fan commented on a change in pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
cloud-fan commented on a change in pull request #28728: URL: https://github.com/apache/spark/pull/28728#discussion_r435325729 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TimestampFormatterSuite.scala ## @@ -418,15 +417,7 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
cloud-fan commented on a change in pull request #28728: URL: https://github.com/apache/spark/pull/28728#discussion_r435325539 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateFormatterSuite.scala ## @@ -199,4 +197,8 @@ class DateFormatterSuite

[GitHub] [spark] cloud-fan commented on a change in pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
cloud-fan commented on a change in pull request #28728: URL: https://github.com/apache/spark/pull/28728#discussion_r435324570 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -234,22 +234,22 @@ private object