[GitHub] [spark] cloud-fan commented on a change in pull request #29349: [SPARK-32528][SQL][TEST] The analyze method should make sure the plan is analyzed

2020-08-07 Thread GitBox
cloud-fan commented on a change in pull request #29349: URL: https://github.com/apache/spark/pull/29349#discussion_r466840447 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PullupCorrelatedPredicatesSuite.scala ## @@ -91,9 +91,8 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #29349: [SPARK-32528][SQL][TEST] The analyze method should make sure the plan is analyzed

2020-08-07 Thread GitBox
cloud-fan commented on a change in pull request #29349: URL: https://github.com/apache/spark/pull/29349#discussion_r466840696 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyCastsSuite.scala ## @@ -42,7 +42,8 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #29349: [SPARK-32528][SQL][TEST] The analyze method should make sure the plan is analyzed

2020-08-07 Thread GitBox
cloud-fan commented on a change in pull request #29349: URL: https://github.com/apache/spark/pull/29349#discussion_r466840338 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinReorderSuite.scala ## @@ -307,9 +307,9 @@ class JoinReorderSuite

[GitHub] [spark] cloud-fan commented on a change in pull request #29349: [SPARK-32528][SQL][TEST] The analyze method should make sure the plan is analyzed

2020-08-07 Thread GitBox
cloud-fan commented on a change in pull request #29349: URL: https://github.com/apache/spark/pull/29349#discussion_r466840097 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala ## @@ -1149,75 +1149,60 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #29349: [SPARK-32528][SQL][TEST] The analyze method should make sure the plan is analyzed

2020-08-07 Thread GitBox
cloud-fan commented on a change in pull request #29349: URL: https://github.com/apache/spark/pull/29349#discussion_r466839986 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BinaryComparisonSimplificationSuite.scala ## @@ -119,9 +119,7 @@

[GitHub] [spark] cloud-fan commented on a change in pull request #29349: [SPARK-32528][SQL][TEST] The analyze method should make sure the plan is analyzed

2020-08-07 Thread GitBox
cloud-fan commented on a change in pull request #29349: URL: https://github.com/apache/spark/pull/29349#discussion_r466839267 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala ## @@ -1149,75 +1149,60 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #29349: [SPARK-32528][SQL][TEST] The analyze method should make sure the plan is analyzed

2020-08-06 Thread GitBox
cloud-fan commented on a change in pull request #29349: URL: https://github.com/apache/spark/pull/29349#discussion_r466362310 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala ## @@ -47,6 +48,13 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #29349: [SPARK-32528][SQL][TEST] The analyze method should make sure the plan is analyzed

2020-08-06 Thread GitBox
cloud-fan commented on a change in pull request #29349: URL: https://github.com/apache/spark/pull/29349#discussion_r466362310 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala ## @@ -47,6 +48,13 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #29349: [SPARK-32528][SQL][TEST] The analyze method should make sure the plan is analyzed

2020-08-06 Thread GitBox
cloud-fan commented on a change in pull request #29349: URL: https://github.com/apache/spark/pull/29349#discussion_r466362107 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala ## @@ -1149,75 +1149,60 @@ class