[GitHub] [spark] cloud-fan commented on a change in pull request #29790: [SPARK-32914][SQL] Avoid calling dataType multiple times for each expression

2020-09-25 Thread GitBox
cloud-fan commented on a change in pull request #29790: URL: https://github.com/apache/spark/pull/29790#discussion_r494807719 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ## @@ -3498,13 +3500,15 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29790: [SPARK-32914][SQL] Avoid calling dataType multiple times for each expression

2020-09-25 Thread GitBox
cloud-fan commented on a change in pull request #29790: URL: https://github.com/apache/spark/pull/29790#discussion_r494807719 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ## @@ -3498,13 +3500,15 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29790: [SPARK-32914][SQL] Avoid calling dataType multiple times for each expression

2020-09-22 Thread GitBox
cloud-fan commented on a change in pull request #29790: URL: https://github.com/apache/spark/pull/29790#discussion_r492551773 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala ## @@ -225,10 +225,13 @@ case class ScalarSubquery(

[GitHub] [spark] cloud-fan commented on a change in pull request #29790: [SPARK-32914][SQL] Avoid calling dataType multiple times for each expression

2020-09-22 Thread GitBox
cloud-fan commented on a change in pull request #29790: URL: https://github.com/apache/spark/pull/29790#discussion_r492552898 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ## @@ -3498,13 +3500,16 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29790: [SPARK-32914][SQL] Avoid calling dataType multiple times for each expression

2020-09-22 Thread GitBox
cloud-fan commented on a change in pull request #29790: URL: https://github.com/apache/spark/pull/29790#discussion_r492553171 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ## @@ -368,7 +368,7 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #29790: [SPARK-32914][SQL] Avoid calling dataType multiple times for each expression

2020-09-22 Thread GitBox
cloud-fan commented on a change in pull request #29790: URL: https://github.com/apache/spark/pull/29790#discussion_r492552680 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ## @@ -3741,11 +3746,13 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #29790: [SPARK-32914][SQL] Avoid calling dataType multiple times for each expression

2020-09-22 Thread GitBox
cloud-fan commented on a change in pull request #29790: URL: https://github.com/apache/spark/pull/29790#discussion_r492551773 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala ## @@ -225,10 +225,13 @@ case class ScalarSubquery(