[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r518536897 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -117,14 +118,37 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517837665 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala ## @@ -146,5 +158,25 @@ private[v2] trait

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517837382 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala ## @@ -146,5 +158,25 @@ private[v2] trait

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517836327 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -863,15 +863,24 @@ object JdbcUtils extends

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517835283 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -117,14 +117,33 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517789478 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -117,14 +117,33 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517135283 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DerbyDialect.scala ## @@ -50,4 +50,17 @@ private object DerbyDialect extends JdbcDialect

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517135401 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -117,14 +117,33 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r515763944 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -117,14 +117,33 @@ class JDBCTabl

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r514896111 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -123,8 +123,14 @@ class JDBCTable

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r514036333 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ## @@ -863,6 +863,7 @@ object JdbcUtils extends L

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r514035984 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala ## @@ -123,8 +123,14 @@ class JDBCTable

[GitHub] [spark] cloud-fan commented on a change in pull request #30154: [SPARK-32405][SQL] Apply table options while creating tables in JDBC Table Catalog

cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r513242844 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -258,6 +258,10 @@ abstract class JdbcDialect extends Serializab