[GitHub] [spark] cloud-fan commented on a change in pull request #30905: [SPARK-33890][SQL] Improve the implement of trim/trimleft/trimright

2020-12-28 Thread GitBox
cloud-fan commented on a change in pull request #30905: URL: https://github.com/apache/spark/pull/30905#discussion_r549605431 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ## @@ -756,6 +756,54 @@ trait

[GitHub] [spark] cloud-fan commented on a change in pull request #30905: [SPARK-33890][SQL] Improve the implement of trim/trimleft/trimright

2020-12-28 Thread GitBox
cloud-fan commented on a change in pull request #30905: URL: https://github.com/apache/spark/pull/30905#discussion_r549604882 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ## @@ -756,6 +756,54 @@ trait

[GitHub] [spark] cloud-fan commented on a change in pull request #30905: [SPARK-33890][SQL] Improve the implement of trim/trimleft/trimright

2020-12-28 Thread GitBox
cloud-fan commented on a change in pull request #30905: URL: https://github.com/apache/spark/pull/30905#discussion_r549253565 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ## @@ -756,6 +756,52 @@ trait

[GitHub] [spark] cloud-fan commented on a change in pull request #30905: [SPARK-33890][SQL] Improve the implement of trim/trimleft/trimright

2020-12-28 Thread GitBox
cloud-fan commented on a change in pull request #30905: URL: https://github.com/apache/spark/pull/30905#discussion_r549253565 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ## @@ -756,6 +756,52 @@ trait

[GitHub] [spark] cloud-fan commented on a change in pull request #30905: [SPARK-33890][SQL] Improve the implement of trim/trimleft/trimright

2020-12-28 Thread GitBox
cloud-fan commented on a change in pull request #30905: URL: https://github.com/apache/spark/pull/30905#discussion_r549253255 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ## @@ -756,6 +756,52 @@ trait

[GitHub] [spark] cloud-fan commented on a change in pull request #30905: [SPARK-33890][SQL] Improve the implement of trim/trimleft/trimright

2020-12-28 Thread GitBox
cloud-fan commented on a change in pull request #30905: URL: https://github.com/apache/spark/pull/30905#discussion_r549253006 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala ## @@ -756,6 +756,52 @@ trait