[GitHub] [spark] cloud-fan commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r572226095 ## File path: sql/core/src/test/resources/sql-tests/inputs/explain-cbo.sql ## @@ -0,0 +1,25 @@ +CREATE TABLE t1(a INT, b INT) USING PARQUET; +CREATE TAB

[GitHub] [spark] cloud-fan commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r572163060 ## File path: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala ## @@ -678,4 +679,49 @@ class StatisticsCollectionSuite exte

[GitHub] [spark] cloud-fan commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r572094831 ## File path: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala ## @@ -678,4 +679,49 @@ class StatisticsCollectionSuite exte

[GitHub] [spark] cloud-fan commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r572092844 ## File path: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala ## @@ -678,4 +679,49 @@ class StatisticsCollectionSuite exte

[GitHub] [spark] cloud-fan commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r572053175 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ## @@ -253,6 +254,15 @@ class QueryExecution( // trigg

[GitHub] [spark] cloud-fan commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r572052721 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ## @@ -253,6 +254,15 @@ class QueryExecution( // trigg

[GitHub] [spark] cloud-fan commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r572014419 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlanVisitor.scala ## @@ -47,6 +49,16 @@ trait LogicalPlanV

[GitHub] [spark] cloud-fan commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r571988475 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlanVisitor.scala ## @@ -47,6 +49,16 @@ trait LogicalPlanV

[GitHub] [spark] cloud-fan commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r571987869 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlanVisitor.scala ## @@ -47,6 +49,16 @@ trait LogicalPlanV