cloud-fan commented on a change in pull request #31500:
URL: https://github.com/apache/spark/pull/31500#discussion_r571994908
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
##########
@@ -1088,4 +1088,6 @@ trait ComplexTypeMergingExpression extends Expression {
* Common base trait for user-defined functions, including UDF/UDAF/UDTF of
different languages
* and Hive function wrappers.
*/
-trait UserDefinedExpression
+trait UserDefinedExpression {
+ def name: String
Review comment:
It's an internal trait, seems OK to require it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
