[GitHub] [spark] cloud-fan commented on a change in pull request #32470: [WIP] Simplify ResolveAggregateFunctions

2021-06-10 Thread GitBox
cloud-fan commented on a change in pull request #32470: URL: https://github.com/apache/spark/pull/32470#discussion_r649027730 ## File path: sql/core/src/test/resources/sql-tests/results/subquery/negative-cases/invalid-correlation.sql.out ## @@ -63,7 +63,7 @@ WHERE t1a IN

[GitHub] [spark] cloud-fan commented on a change in pull request #32470: [WIP] Simplify ResolveAggregateFunctions

2021-06-10 Thread GitBox
cloud-fan commented on a change in pull request #32470: URL: https://github.com/apache/spark/pull/32470#discussion_r649026895 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveGroupingAnalyticsSuite.scala ## @@ -287,9 +287,9 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #32470: [WIP] Simplify ResolveAggregateFunctions

2021-06-10 Thread GitBox
cloud-fan commented on a change in pull request #32470: URL: https://github.com/apache/spark/pull/32470#discussion_r649008968 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q35.sf100/explain.txt ## @@ -306,11 +306,11 @@ Input [19]:

[GitHub] [spark] cloud-fan commented on a change in pull request #32470: [WIP] Simplify ResolveAggregateFunctions

2021-06-10 Thread GitBox
cloud-fan commented on a change in pull request #32470: URL: https://github.com/apache/spark/pull/32470#discussion_r649009205 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q35/explain.txt ## @@ -251,11 +251,11 @@ Input [19]: [ca_state#23,

[GitHub] [spark] cloud-fan commented on a change in pull request #32470: [WIP] Simplify ResolveAggregateFunctions

2021-06-10 Thread GitBox
cloud-fan commented on a change in pull request #32470: URL: https://github.com/apache/spark/pull/32470#discussion_r649009772 ## File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v2_7/q6.sf100/explain.txt ## @@ -267,15 +267,15 @@ Input [2]: