[GitHub] [spark] cloud-fan commented on a change in pull request #32849: [WIP][SPARK-35704][SQL] Support fields by the day-time interval type

2021-06-10 Thread GitBox
cloud-fan commented on a change in pull request #32849: URL: https://github.com/apache/spark/pull/32849#discussion_r648989267 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala ## @@ -75,7 +75,7 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #32849: [WIP][SPARK-35704][SQL] Support fields by the day-time interval type

2021-06-10 Thread GitBox
cloud-fan commented on a change in pull request #32849: URL: https://github.com/apache/spark/pull/32849#discussion_r648984100 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DayTimeIntervalType.scala ## @@ -57,16 +62,61 @@ class DayTimeIntervalType

[GitHub] [spark] cloud-fan commented on a change in pull request #32849: [WIP][SPARK-35704][SQL] Support fields by the day-time interval type

2021-06-10 Thread GitBox
cloud-fan commented on a change in pull request #32849: URL: https://github.com/apache/spark/pull/32849#discussion_r648978557 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala ## @@ -158,7 +158,10 @@ object IntervalUtils {

[GitHub] [spark] cloud-fan commented on a change in pull request #32849: [WIP][SPARK-35704][SQL] Support fields by the day-time interval type

2021-06-10 Thread GitBox
cloud-fan commented on a change in pull request #32849: URL: https://github.com/apache/spark/pull/32849#discussion_r648971845 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala ## @@ -405,8 +405,9 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #32849: [WIP][SPARK-35704][SQL] Support fields by the day-time interval type

2021-06-10 Thread GitBox
cloud-fan commented on a change in pull request #32849: URL: https://github.com/apache/spark/pull/32849#discussion_r648970057 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala ## @@ -95,7 +95,7 @@ case class