cloud-fan commented on code in PR #37327: URL: https://github.com/apache/spark/pull/37327#discussion_r932204473
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala: ########## @@ -153,19 +153,24 @@ class CSVOptions( * Disabled by default for backwards compatibility and performance. When enabled, date entries in * timestamp columns will be cast to timestamp upon parsing. Not compatible with * legacyTimeParserPolicy == LEGACY since legacy date parser will accept extra trailing characters + * + * The flag is only enabled if inferSchema is set to true. */ - val inferDate = { - val inferDateFlag = getBool("inferDate") - if (SQLConf.get.legacyTimeParserPolicy == LegacyBehaviorPolicy.LEGACY && inferDateFlag) { + val preferDate = { + val preferDateFlag = getBool("preferDate") + if (preferDateFlag && SQLConf.get.legacyTimeParserPolicy == LegacyBehaviorPolicy.LEGACY) { throw QueryExecutionErrors.inferDateWithLegacyTimeParserError() } - inferDateFlag + if (preferDateFlag && !inferSchemaFlag) { Review Comment: I'd prefer to fix doc. This renaming is kind of "redefine" this option, and it doesn't make sense to bind `preferDate` to ``inferSchema`. ########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala: ########## @@ -153,19 +153,24 @@ class CSVOptions( * Disabled by default for backwards compatibility and performance. When enabled, date entries in * timestamp columns will be cast to timestamp upon parsing. Not compatible with * legacyTimeParserPolicy == LEGACY since legacy date parser will accept extra trailing characters + * + * The flag is only enabled if inferSchema is set to true. */ - val inferDate = { - val inferDateFlag = getBool("inferDate") - if (SQLConf.get.legacyTimeParserPolicy == LegacyBehaviorPolicy.LEGACY && inferDateFlag) { + val preferDate = { + val preferDateFlag = getBool("preferDate") + if (preferDateFlag && SQLConf.get.legacyTimeParserPolicy == LegacyBehaviorPolicy.LEGACY) { throw QueryExecutionErrors.inferDateWithLegacyTimeParserError() } - inferDateFlag + if (preferDateFlag && !inferSchemaFlag) { Review Comment: I'd prefer to fix doc. This renaming is kind of "redefine" this option, and it doesn't make sense to bind `preferDate` to `inferSchema`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org