[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r979572820 ## sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala: ## @@ -148,13 +148,19 @@ private[sql] class SharedState( val externalCatalog =

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r979572317 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala: ## @@ -1932,6 +1932,13 @@ private[sql] object QueryExecutionErrors extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r978389370 ## core/src/main/resources/error/error-classes.json: ## @@ -70,6 +70,11 @@ ], "sqlState" : "22008" }, + "DEFAULT_CATALOG_DATABASE_NOT_EXISTS" : {

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r977124693 ## sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala: ## @@ -36,7 +36,7 @@ import org.apache.spark.SparkFunSuite import org.apache.spark.sql._

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r977124552 ## sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala: ## @@ -148,13 +148,18 @@ private[sql] class SharedState( val externalCatalog =

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r977124092 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala: ## @@ -43,7 +44,7 @@ class V2SessionCatalog(catalog: SessionCatalog)

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r975366440 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/CatalogManagerSuite.scala: ## @@ -33,7 +33,7 @@ class CatalogManagerSuite extends SparkFunSuite

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r975364879 ## sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala: ## @@ -148,13 +148,18 @@ private[sql] class SharedState( val externalCatalog =

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r975365487 ## sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala: ## @@ -361,7 +360,7 @@ private[sql] trait SQLTestUtilsBase try f(dbName) finally {

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r975364374 ## sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala: ## @@ -148,13 +148,18 @@ private[sql] class SharedState( val externalCatalog =

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r975362828 ## sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala: ## @@ -130,7 +130,7 @@ class CatalogManager( _currentNamespace =

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r975361715 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -1846,23 +1848,23 @@ class SessionCatalog( // -

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r975361460 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -1846,23 +1848,23 @@ class SessionCatalog( // -

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r974888079 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -48,9 +48,6 @@ import org.apache.spark.sql.types.StructType import

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r973875374 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -286,7 +284,7 @@ class SessionCatalog( def dropDatabase(db:

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r973074675 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -286,7 +284,7 @@ class SessionCatalog( def dropDatabase(db:

[GitHub] [spark] cloud-fan commented on a diff in pull request #37679: [SPARK-35242][SQL] Support changing session catalog's default database

cloud-fan commented on code in PR #37679: URL: https://github.com/apache/spark/pull/37679#discussion_r964775576 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala: ## @@ -286,7 +284,7 @@ class SessionCatalog( def dropDatabase(db: