[GitHub] [spark] cloud-fan commented on a diff in pull request #37746: [SPARK-40293][SQL] Make the V2 table error message more meaningful

2022-09-05 Thread GitBox
cloud-fan commented on code in PR #37746: URL: https://github.com/apache/spark/pull/37746#discussion_r963258197 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -541,8 +541,13 @@ private[sql] object QueryCompilationErrors extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #37746: [SPARK-40293][SQL] Make the V2 table error message more meaningful

2022-09-05 Thread GitBox
cloud-fan commented on code in PR #37746: URL: https://github.com/apache/spark/pull/37746#discussion_r963257578 ## core/src/main/resources/error/error-classes.json: ## @@ -565,6 +565,11 @@ " is a reserved table property, ." ] }, +

[GitHub] [spark] cloud-fan commented on a diff in pull request #37746: [SPARK-40293][SQL] Make the V2 table error message more meaningful

2022-09-05 Thread GitBox
cloud-fan commented on code in PR #37746: URL: https://github.com/apache/spark/pull/37746#discussion_r963257429 ## core/src/main/resources/error/error-classes.json: ## @@ -565,6 +565,11 @@ " is a reserved table property, ." ] }, +

[GitHub] [spark] cloud-fan commented on a diff in pull request #37746: [SPARK-40293][SQL] Make the V2 table error message more meaningful

2022-09-02 Thread GitBox
cloud-fan commented on code in PR #37746: URL: https://github.com/apache/spark/pull/37746#discussion_r961379227 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala: ## @@ -50,28 +50,44 @@ class ResolveSessionCatalog(val catalogManager:

[GitHub] [spark] cloud-fan commented on a diff in pull request #37746: [SPARK-40293][SQL] Make the V2 table error message more meaningful

2022-09-02 Thread GitBox
cloud-fan commented on code in PR #37746: URL: https://github.com/apache/spark/pull/37746#discussion_r961379227 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala: ## @@ -50,28 +50,44 @@ class ResolveSessionCatalog(val catalogManager:

[GitHub] [spark] cloud-fan commented on a diff in pull request #37746: [SPARK-40293][SQL] Make the V2 table error message more meaningful

2022-09-02 Thread GitBox
cloud-fan commented on code in PR #37746: URL: https://github.com/apache/spark/pull/37746#discussion_r961378514 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -541,8 +541,15 @@ private[sql] object QueryCompilationErrors extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #37746: [SPARK-40293][SQL] Make the V2 table error message more meaningful

2022-09-02 Thread GitBox
cloud-fan commented on code in PR #37746: URL: https://github.com/apache/spark/pull/37746#discussion_r961377593 ## core/src/main/resources/error/error-classes.json: ## @@ -520,6 +520,11 @@ "NATURAL CROSS JOIN." ] }, + "TABLE_OPERATION" : { +

[GitHub] [spark] cloud-fan commented on a diff in pull request #37746: [SPARK-40293][SQL] Make the V2 table error message more meaningful

2022-09-01 Thread GitBox
cloud-fan commented on code in PR #37746: URL: https://github.com/apache/spark/pull/37746#discussion_r960285847 ## core/src/main/resources/error/error-classes.json: ## @@ -520,6 +520,11 @@ "NATURAL CROSS JOIN." ] }, +

[GitHub] [spark] cloud-fan commented on a diff in pull request #37746: [SPARK-40293][SQL] Make the V2 table error message more meaningful

2022-09-01 Thread GitBox
cloud-fan commented on code in PR #37746: URL: https://github.com/apache/spark/pull/37746#discussion_r960285081 ## core/src/main/resources/error/error-classes.json: ## @@ -520,6 +520,11 @@ "NATURAL CROSS JOIN." ] }, +

[GitHub] [spark] cloud-fan commented on a diff in pull request #37746: [SPARK-40293][SQL] Make the V2 table error message more meaningful

2022-09-01 Thread GitBox
cloud-fan commented on code in PR #37746: URL: https://github.com/apache/spark/pull/37746#discussion_r960284889 ## core/src/main/resources/error/error-classes.json: ## @@ -520,6 +520,11 @@ "NATURAL CROSS JOIN." ] }, +

[GitHub] [spark] cloud-fan commented on a diff in pull request #37746: [SPARK-40293][SQL] Make the V2 table error message more meaningful

2022-08-31 Thread GitBox
cloud-fan commented on code in PR #37746: URL: https://github.com/apache/spark/pull/37746#discussion_r960213508 ## sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala: ## @@ -542,7 +542,9 @@ private[sql] object QueryCompilationErrors extends