[GitHub] [spark] cloud-fan commented on a diff in pull request #38406: [SPARK-40926][CONNECT] Refactor server side tests to only use DataFrame API

cloud-fan commented on code in PR #38406: URL: https://github.com/apache/spark/pull/38406#discussion_r100731 ## connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala: ## @@ -215,4 +180,16 @@ class SparkConnectProtoSuite extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #38406: [SPARK-40926][CONNECT] Refactor server side tests to only use DataFrame API

cloud-fan commented on code in PR #38406: URL: https://github.com/apache/spark/pull/38406#discussion_r100731 ## connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala: ## @@ -215,4 +180,16 @@ class SparkConnectProtoSuite extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #38406: [SPARK-40926][CONNECT] Refactor server side tests to only use DataFrame API

cloud-fan commented on code in PR #38406: URL: https://github.com/apache/spark/pull/38406#discussion_r1006523933 ## connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala: ## @@ -215,4 +180,16 @@ class SparkConnectProtoSuite extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #38406: [SPARK-40926][CONNECT] Refactor server side tests to only use DataFrame API

cloud-fan commented on code in PR #38406: URL: https://github.com/apache/spark/pull/38406#discussion_r1006412665 ## connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ## @@ -67,7 +67,7 @@ class SparkConnectPlanner(plan:

[GitHub] [spark] cloud-fan commented on a diff in pull request #38406: [SPARK-40926][CONNECT] Refactor server side tests to only use DataFrame API

cloud-fan commented on code in PR #38406: URL: https://github.com/apache/spark/pull/38406#discussion_r1006402614 ## connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala: ## @@ -215,4 +180,16 @@ class SparkConnectProtoSuite extends

[GitHub] [spark] cloud-fan commented on a diff in pull request #38406: [SPARK-40926][CONNECT] Refactor server side tests to only use DataFrame API

cloud-fan commented on code in PR #38406: URL: https://github.com/apache/spark/pull/38406#discussion_r1006351737 ## connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala: ## @@ -30,181 +36,140 @@ import

[GitHub] [spark] cloud-fan commented on a diff in pull request #38406: [SPARK-40926][CONNECT] Refactor server side tests to only use DataFrame API

cloud-fan commented on code in PR #38406: URL: https://github.com/apache/spark/pull/38406#discussion_r1006348403 ## connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala: ## @@ -30,181 +36,140 @@ import