[GitHub] [spark] cloud-fan commented on a diff in pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

cloud-fan commented on code in PR #40116: URL: https://github.com/apache/spark/pull/40116#discussion_r1152647858 ## sql/core/src/main/scala/org/apache/spark/sql/SQLImplicits.scala: ## @@ -45,7 +45,7 @@ abstract class SQLImplicits extends LowPrioritySQLImplicits { } //

[GitHub] [spark] cloud-fan commented on a diff in pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

cloud-fan commented on code in PR #40116: URL: https://github.com/apache/spark/pull/40116#discussion_r1151519181 ## sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala: ## @@ -1136,6 +1136,17 @@ class DataFrameSuite extends QueryTest

[GitHub] [spark] cloud-fan commented on a diff in pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

cloud-fan commented on code in PR #40116: URL: https://github.com/apache/spark/pull/40116#discussion_r1151518642 ## sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala: ## @@ -89,7 +89,12 @@ class RelationalGroupedDataset protected[sql]( case expr:

[GitHub] [spark] cloud-fan commented on a diff in pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

cloud-fan commented on code in PR #40116: URL: https://github.com/apache/spark/pull/40116#discussion_r1139884033 ## sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala: ## @@ -89,9 +89,22 @@ class RelationalGroupedDataset protected[sql]( case expr:

[GitHub] [spark] cloud-fan commented on a diff in pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

cloud-fan commented on code in PR #40116: URL: https://github.com/apache/spark/pull/40116#discussion_r1138054456 ## sql/core/src/main/scala/org/apache/spark/sql/SQLImplicits.scala: ## @@ -40,12 +40,15 @@ abstract class SQLImplicits extends LowPrioritySQLImplicits { */

[GitHub] [spark] cloud-fan commented on a diff in pull request #40116: [SPARK-41391][SQL] The output column name of groupBy.agg(count_distinct) is incorrect

cloud-fan commented on code in PR #40116: URL: https://github.com/apache/spark/pull/40116#discussion_r1121370471 ## sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala: ## @@ -89,9 +89,18 @@ class RelationalGroupedDataset protected[sql]( case expr: