[GitHub] [spark] cloud-fan commented on a diff in pull request #41475: [SPARK-43979][SQL] CollectedMetrics should be treated as the same one for self-join

2023-06-06 Thread via GitHub
cloud-fan commented on code in PR #41475: URL: https://github.com/apache/spark/pull/41475#discussion_r1220669782 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -1064,6 +1066,31 @@ trait CheckAnalysis extends PredicateHelper with

[GitHub] [spark] cloud-fan commented on a diff in pull request #41475: [SPARK-43979][SQL] CollectedMetrics should be treated as the same one for self-join

2023-06-06 Thread via GitHub
cloud-fan commented on code in PR #41475: URL: https://github.com/apache/spark/pull/41475#discussion_r1220669363 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -1064,6 +1066,31 @@ trait CheckAnalysis extends PredicateHelper with

[GitHub] [spark] cloud-fan commented on a diff in pull request #41475: [SPARK-43979][SQL] CollectedMetrics should be treated as the same one for self-join

2023-06-06 Thread via GitHub
cloud-fan commented on code in PR #41475: URL: https://github.com/apache/spark/pull/41475#discussion_r1219586024 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala: ## @@ -1064,6 +1066,32 @@ trait CheckAnalysis extends PredicateHelper with