[GitHub] [spark] cloud-fan commented on a diff in pull request #42661: [SPARK-44743][SQL] Add `try_reflect` function

cloud-fan commented on code in PR #42661: URL: https://github.com/apache/spark/pull/42661#discussion_r1306954376 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TryEval.scala: ## @@ -236,3 +236,35 @@ case class TryToBinary( override protected def with

[GitHub] [spark] cloud-fan commented on a diff in pull request #42661: [SPARK-44743][SQL] Add `try_reflect` function

cloud-fan commented on code in PR #42661: URL: https://github.com/apache/spark/pull/42661#discussion_r1306915491 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TryEval.scala: ## @@ -236,3 +236,35 @@ case class TryToBinary( override protected def with

[GitHub] [spark] cloud-fan commented on a diff in pull request #42661: [SPARK-44743][SQL] Add `try_reflect` function

cloud-fan commented on code in PR #42661: URL: https://github.com/apache/spark/pull/42661#discussion_r1306914923 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala: ## @@ -133,8 +138,13 @@ case class CallMethodViaReflection(chi

[GitHub] [spark] cloud-fan commented on a diff in pull request #42661: [SPARK-44743][SQL] Add `try_reflect` function

cloud-fan commented on code in PR #42661: URL: https://github.com/apache/spark/pull/42661#discussion_r1306869761 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala: ## @@ -55,64 +55,73 @@ import org.apache.spark.util.Utils "

[GitHub] [spark] cloud-fan commented on a diff in pull request #42661: [SPARK-44743][SQL] Add `try_reflect` function

cloud-fan commented on code in PR #42661: URL: https://github.com/apache/spark/pull/42661#discussion_r1306864355 ## sql/core/src/test/resources/sql-tests/inputs/try_reflect.sql: ## @@ -0,0 +1,19 @@ +-- positive +SELECT try_reflect("java.util.UUID", "fromString", "a5cf6c42-0c85-

[GitHub] [spark] cloud-fan commented on a diff in pull request #42661: [SPARK-44743][SQL] Add `try_reflect` function

cloud-fan commented on code in PR #42661: URL: https://github.com/apache/spark/pull/42661#discussion_r1306863750 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala: ## @@ -55,64 +55,73 @@ import org.apache.spark.util.Utils "

[GitHub] [spark] cloud-fan commented on a diff in pull request #42661: [SPARK-44743][SQL] Add `try_reflect` function

cloud-fan commented on code in PR #42661: URL: https://github.com/apache/spark/pull/42661#discussion_r1305689424 ## sql/core/src/test/scala/org/apache/spark/sql/MiscFunctionsSuite.scala: ## @@ -242,6 +242,19 @@ class MiscFunctionsSuite extends QueryTest with SharedSparkSession

[GitHub] [spark] cloud-fan commented on a diff in pull request #42661: [SPARK-44743][SQL] Add `try_reflect` function

cloud-fan commented on code in PR #42661: URL: https://github.com/apache/spark/pull/42661#discussion_r1305688138 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TryEval.scala: ## @@ -236,3 +236,31 @@ case class TryToBinary( override protected def with

[GitHub] [spark] cloud-fan commented on a diff in pull request #42661: [SPARK-44743][SQL] Add `try_reflect` function

cloud-fan commented on code in PR #42661: URL: https://github.com/apache/spark/pull/42661#discussion_r1305687113 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala: ## @@ -133,8 +141,15 @@ case class CallMethodViaReflection(chi

[GitHub] [spark] cloud-fan commented on a diff in pull request #42661: [SPARK-44743][SQL] Add `try_reflect` function

cloud-fan commented on code in PR #42661: URL: https://github.com/apache/spark/pull/42661#discussion_r1305686439 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala: ## @@ -55,10 +57,16 @@ import org.apache.spark.util.Utils "