[GitHub] [spark] cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-08-13 Thread GitBox
cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#issuecomment-521117919 thanks, merging to master! This is an automated message from t

[GitHub] [spark] cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-08-12 Thread GitBox
cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#issuecomment-520675085 LGTM. Shall we also update the RENAME TABLE command? I'm fine if we create a ticket and do it in a follow-up.

[GitHub] [spark] cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-08-12 Thread GitBox
cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#issuecomment-520674298 ok to test This is an automated message from the Apache Git Se

[GitHub] [spark] cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-08-05 Thread GitBox
cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#issuecomment-518133638 > We're just changing the full table name, including namespace, instead of just the short name. If by definition namespa

[GitHub] [spark] cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-08-01 Thread GitBox
cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#issuecomment-517173877 Hey, I'm not against the ability to move tables between namespaces, I'm against doing this via `RENAME TABLE`. The example of m

[GitHub] [spark] cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-07-31 Thread GitBox
cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#issuecomment-516826613 @rdblue IMO, we should first think about what behavior Spark should provide to end-users, and then design the Data Source API t

[GitHub] [spark] cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-07-21 Thread GitBox
cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#issuecomment-513635512 Let's enforce that to be consistent with the existing behaviors. --

[GitHub] [spark] cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-07-21 Thread GitBox
cloud-fan commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#issuecomment-513532914 > but we do need to decide whether to require that both identifiers start with the same catalog A similar problem was al