cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-733763043
This PR is definitely not related to Spark R. Since jenkins is flaky now,
I'm merging it first. Will keep watching the jenkins status.
---
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-733746002
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-733560590
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-733455283
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-733402087
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-733019331
@rdblue there are several mistakes in my previous PR that cause test
failures, I'm fixing them in https://github.com/rdblue/spark/pull/9
-
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-732745010
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-732692249
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-730590643
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-728300096
Hi @rdblue , I created a PR against your branch to address my review
comments (PR: https://github.com/rdblue/spark/pull/8), to save your time and
speed up the progress here. C
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-707245498
This branch has gone stale very far, so it's hard for me to make changes
against this branch. If you insist on continuing this PR, I can wait for you
and review it later.
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-707228025
Hi @rdblue , I've already ported the parser change of this PR to our
internal fork and tested it with real queries, do you mind if I create a PR for
the parser change first? I
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-625749455
> Are you saying that a Hive catalog plugin and table implementation would
be forced to implement Spark's incompatible behavior somehow?
I'm saying the Hive behavior abo
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-625091035
> Spark makes an arbitrary choice to disallow something that is valid to a
catalog
It's not arbitrary. Spark just treats EXTERNAL as an auxiliary keyword and
it must ap
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-624077549
This is not an issue before because we didn't translate the Hive-style
CREATE TABLE statement to catalog plugin operations.
Note that: our goal is to unify the CREATE TA
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-621823593
hmm, it's weird to add a feature first and have a discussion later to remove
it or not. I think it's more common to start without the arguable feature first
and then have a di
cloud-fan commented on pull request #28026:
URL: https://github.com/apache/spark/pull/28026#issuecomment-620582149
> ... and be questioned if it behaves differently.
That's already the case. Spark is not 100% compatible with Hive, and
`EXTERNAL` for example is not exactly the same w
17 matches
Mail list logo
